Stream: git-wasmtime

Topic: wasmtime / issue #3587 cranelift-codegen: depend on an ex...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 22:37):

fitzgen commented on issue #3587:

I wonder if we're also going to have an issue with using the isle crate name (in Cargo.toml here) rather than cranelift-isle, since (as you discovered) it's reserved right now? Should we update that in this PR as well?

I don't think this is an issue, as we had peepmatic and not cranelift-peepmatic and everything worked.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 22:42):

cfallin commented on issue #3587:

I wonder if we're also going to have an issue with using the isle crate name (in Cargo.toml here) rather than cranelift-isle, since (as you discovered) it's reserved right now? Should we update that in this PR as well?

I don't think this is an issue, as we had peepmatic and not cranelift-peepmatic and everything worked.

Is the crate not published, then? I guess I don't fully understand exactly how we determine which crates are published; if dev-dependencies don't go to crates.io then indeed, everything should just work, and nevermind me!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 22:46):

fitzgen commented on issue #3587:

Ah no, this is me failing my reading comprehension. The isle crate name is already taken on crates.io, and this is what I was failing to understand.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 22:46):

fitzgen commented on issue #3587:

So yeah, I think cranelift-isle is the way to go.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 22:55):

fitzgen commented on issue #3587:

The rename to cranelift-isle is done now.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2021 at 23:18):

github-actions[bot] commented on issue #3587:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 12:05 UTC