github-actions[bot] commented on issue #3582:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Amanieu commented on issue #3582:
CI failure is unrelated to this PR, it's a new warning from the latest Rust stable release.
fitzgen commented on issue #3582:
Thanks for the PR!
I don't think I'm familiar enough with the C API or our implementation of it to give this a proper review, especially on a Friday. @alexcrichton can take a look in a week and a half, or maybe someone else on the team feels confident enough to review this before then.
peterhuene commented on issue #3582:
It looks like a fix for the build issues has been merged, so this should be good to rebase now.
Amanieu commented on issue #3582:
Rebased.
peterhuene commented on issue #3582:
@Amanieu Thanks again for the fixes!
Last updated: Dec 23 2024 at 12:05 UTC