Stream: git-wasmtime

Topic: wasmtime / issue #3582 Fix issues with the C API vector i...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2021 at 01:19):

github-actions[bot] commented on issue #3582:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2021 at 05:06):

Amanieu commented on issue #3582:

CI failure is unrelated to this PR, it's a new warning from the latest Rust stable release.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2021 at 17:42):

fitzgen commented on issue #3582:

Thanks for the PR!

I don't think I'm familiar enough with the C API or our implementation of it to give this a proper review, especially on a Friday. @alexcrichton can take a look in a week and a half, or maybe someone else on the team feels confident enough to review this before then.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2021 at 21:17):

peterhuene commented on issue #3582:

It looks like a fix for the build issues has been merged, so this should be good to rebase now.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 03 2021 at 23:57):

Amanieu commented on issue #3582:

Rebased.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 04 2021 at 01:45):

peterhuene commented on issue #3582:

@Amanieu Thanks again for the fixes!

Last updated: Nov 22 2024 at 16:03 UTC