Stream: git-wasmtime

Topic: wasmtime / issue #3575 ISLE: explicitly define rule-order...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2021 at 20:23):

cfallin opened issue #3575:

Right now, the ISLE compiler prioritizes matching "more specific rules first" when building the decision trie that becomes the generated code.

This is somewhat intuitive, but also imprecise. The actual details depend on subtle workings of the trie construction. We should:

  1. Define a proper total ordering over all patterns, which can be understood independently of compiler implementation details and reasoned about intuitively; and
  2. Implement this in place of the current system.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2021 at 21:02):

alexcrichton labeled issue #3575:

Right now, the ISLE compiler prioritizes matching "more specific rules first" when building the decision trie that becomes the generated code.

This is somewhat intuitive, but also imprecise. The actual details depend on subtle workings of the trie construction. We should:

  1. Define a proper total ordering over all patterns, which can be understood independently of compiler implementation details and reasoned about intuitively; and
  2. Implement this in place of the current system.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 30 2021 at 21:02):

github-actions[bot] commented on issue #3575:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 20:02):

cfallin labeled issue #3575:

Right now, the ISLE compiler prioritizes matching "more specific rules first" when building the decision trie that becomes the generated code.

This is somewhat intuitive, but also imprecise. The actual details depend on subtle workings of the trie construction. We should:

  1. Define a proper total ordering over all patterns, which can be understood independently of compiler implementation details and reasoned about intuitively; and
  2. Implement this in place of the current system.

Last updated: Dec 23 2024 at 12:05 UTC