Stream: git-wasmtime

Topic: wasmtime / issue #3534 ISLE: guard against stale generate...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 07:54):

github-actions[bot] commented on issue #3534:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 19:34):

cfallin commented on issue #3534:

@alexcrichton That's an excellent idea -- I've refactored now so that it always computes the manifest, and then either rebuilds or errors out when a recompilation is required, depending on the rebuild-isle feature. Let me know what you think!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 23:01):

cfallin commented on issue #3534:

Just an interesting data point: some of the latest CI failures were because this PR needed a rebase, so the manifest hashes were out-of-date with respect to latest main. This is actually what we want and I'm happy to see it worked: otherwise, if we allow merges of non-rebased ISLE source, the checked-in generated source will go through a git merge as well and who knows how well that'd correspond (due to e.g. renumbered temps, different trie build orders, etc).

Also I had to disable the ISLE build logic via a special Cargo feature in the "Meta deterministic check"; as explained in the commit message, this runs the build script outside of the source tree, which worked previously because the default build options did not look for ISLE source, but now they do. The CI job is checking other output (unrelated to ISLE) though, so this seems fine.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2021 at 23:24):

cfallin commented on issue #3534:

Cool, yeah, we can maybe think more about this at the same time that we think about whether we want to check in the meta-DSL-generated source too (which IIRC we've discussed as a way to reduce compile time). I'll leave it as-is for this PR and create a followup issue to track it.

Last updated: Nov 22 2024 at 16:03 UTC