Stream: git-wasmtime

Topic: wasmtime / issue #3519 cargo workspaces break `wiggle::fr...

Wasmtime GitHub notifications bot (Nov 14 2021 at 01:23):

ryankurte opened issue #3519:

when using wiggle::from_witx adding a crate to a workspace breaks inclusion of of witx files.
the wiggle docs suggest this is based on CARGO_MANIFEST_DIR, but i believe this should always be the package manifest directory.

Wasmtime GitHub notifications bot (Nov 15 2021 at 17:27):

pchickey commented on issue #3519:

Can you describe in more detail how to reproduce this issue?

For reference when we use wiggle in wasi-common we use build.rs to create an environment variable WASI_ROOT so that the witx files can be used by the crate and its dependents (wasmtime-wasi, lucet-wasi, etc) https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/snapshots/preview_1.rs#L22

Wasmtime GitHub notifications bot (Dec 09 2021 at 08:46):

ryankurte commented on issue #3519:

huh, WASI_ROOT seems like it should solve the problem, but i don't seem to be using it correctly...

minimal example uploaded here, you can swap spec from excluded to members in the workspace file which changes the base path in the codegen macro so the .witx files can no-longer be found.

Wasmtime GitHub notifications bot (Dec 09 2021 at 08:46):

ryankurte edited a comment on issue #3519:

hey thanks for the response! WASI_ROOT seems like it should solve the problem, but i don't seem to be using it correctly...

minimal example uploaded here, you can swap spec from excluded to members in the workspace file which changes the base path in the codegen macro so the .witx files can no-longer be found.

Last updated: Nov 22 2024 at 16:03 UTC