Stream: git-wasmtime

Topic: wasmtime / issue #3456 List exports of an instance in lin...

Wasmtime GitHub notifications bot (Oct 16 2021 at 21:57):

github-actions[bot] commented on issue #3456:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Oct 16 2021 at 22:13):

adamrk commented on issue #3456:

@alexcrichton I guess it makes sense for you to review because you put up the issue?

Wasmtime GitHub notifications bot (Oct 18 2021 at 15:25):

alexcrichton commented on issue #3456:

Thanks for this! Given that Linker does the automatic translation from set-of-items to instance though would it be possible to make the error message a bit smarter and look for the item that's not actually defined? That I think would produce the best error message to indicate what precisely is missing.

Wasmtime GitHub notifications bot (Oct 18 2021 at 21:23):

adamrk commented on issue #3456:

No problem, changed it to have foo::bar matching the error without linking.

Wasmtime GitHub notifications bot (Oct 20 2021 at 21:31):

alexcrichton commented on issue #3456:

Thanks again!

Last updated: Nov 22 2024 at 16:03 UTC