Stream: git-wasmtime

Topic: wasmtime / issue #3371 Regression : GDB/JIT symbols requ...

Wasmtime GitHub notifications bot (Sep 20 2021 at 14:00):

adv-sw opened issue #3371:

crates/runtime/src/helpers.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/crates/runtime/src/helpers.c b/crates/runtime/src/helpers.c
index 4865928a1..c743e244e 100644
--- a/crates/runtime/src/helpers.c
+++ b/crates/runtime/src/helpers.c
@@ -42,7 +42,12 @@ void wasmtime_longjmp(void *JmpBuf) {
// Note the weak linkage here, though, which is intended to let other code
// override this symbol if it's defined elsewhere, since this definition doesn't
// matter.
-#ifndef CFG_TARGET_OS_windows
+
+
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
__attribute__((weak, noinline))
#endif
void __jit_debug_register_code() {
@@ -61,7 +66,10 @@ struct JITDescriptor {
// Note the weak linkage here which is the same purpose as above. We want to
// let other runtimes be able to override this since our own definition isn't
// important.
-#ifndef CFG_TARGET_OS_windows
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
__attribute__((weak))
#endif
struct JITDescriptor __jit_debug_descriptor = {1, 0, NULL, NULL};

Wasmtime GitHub notifications bot (Sep 20 2021 at 17:33):

alexcrichton commented on issue #3371:

Fixed by https://github.com/bytecodealliance/wasmtime/pull/3373

Wasmtime GitHub notifications bot (Sep 20 2021 at 17:33):

alexcrichton closed issue #3371:

crates/runtime/src/helpers.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/crates/runtime/src/helpers.c b/crates/runtime/src/helpers.c
index 4865928a1..c743e244e 100644
--- a/crates/runtime/src/helpers.c
+++ b/crates/runtime/src/helpers.c
@@ -42,7 +42,12 @@ void wasmtime_longjmp(void *JmpBuf) {
// Note the weak linkage here, though, which is intended to let other code
// override this symbol if it's defined elsewhere, since this definition doesn't
// matter.
-#ifndef CFG_TARGET_OS_windows
+
+
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
__attribute__((weak, noinline))
#endif
void __jit_debug_register_code() {
@@ -61,7 +66,10 @@ struct JITDescriptor {
// Note the weak linkage here which is the same purpose as above. We want to
// let other runtimes be able to override this since our own definition isn't
// important.
-#ifndef CFG_TARGET_OS_windows
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
__attribute__((weak))
#endif
struct JITDescriptor __jit_debug_descriptor = {1, 0, NULL, NULL};

Last updated: Nov 22 2024 at 16:03 UTC