Stream: git-wasmtime

Topic: wasmtime / issue #3320 cranelift: Created test for Function

view this post on Zulip Wasmtime GitHub notifications bot (Sep 09 2021 at 15:04):

antonromanov1 commented on issue #3320:

@cfallin please take a look.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 09 2021 at 15:33):

antonromanov1 commented on issue #3320:

@afonso360 please take a look.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 09 2021 at 17:51):

cfallin commented on issue #3320:

Hi @antonromanov1 -- thanks for the PR! Could you fill in the PR description with some text that explains this PR?

In particular: I'm curious, is there any particular reason you found that indicates we need a two-line test for Function::new() to create an empty function, and nothing else? The Function::new() function is pretty well covered already by all of our other tests that create functions.

To be clear, I'm not at all opposed to "simple" tests if there's a good reason for them, and especially as a nice way for new folks to get started with our codebase; we should just have a good reason for them :-)

view this post on Zulip Wasmtime GitHub notifications bot (Sep 09 2021 at 18:52):

antonromanov1 commented on issue #3320:

@cfallin my test also covers method Function::is_leaf (moreover it asserts the returning value).

view this post on Zulip Wasmtime GitHub notifications bot (Sep 11 2021 at 09:29):

antonromanov1 commented on issue #3320:

@cfallin I added assert on is_block_basic method.

Last updated: Oct 23 2024 at 20:03 UTC