Wasmtime GitHub notifications bot (Sep 09 2021 at 09:01): Wasmtime GitHub notifications bot (Sep 09 2021 at 09:01):dheaton-arm commented on issue #3317:
Happy to address the iterator chain comment.
Regarding the idea to factor out commonality between un/signed cases, I think that would work, but may be easier to do (given that the unsigned and signed variants are in separate branches / PRs at the moment) either as a follow-up patch after both of these are merged, or after one of them merge and then implemented in the remaining PR.
Wasmtime GitHub notifications bot (Sep 09 2021 at 17:36):cfallin commented on issue #3317:
Yep, a followup that factors things appropriately (maybe across any other signed/unsigned pairs as appropriate too) would be perfectly fine, thanks!
Last updated: Nov 22 2024 at 17:03 UTC