github-actions[bot] commented on issue #3298:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api, wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton commented on issue #3298:
Pondering this more, I'm not happy with this. I'm going to try the alternate strategies to speed up
Func::call
and see what happens.
alexcrichton commented on issue #3298:
Ok I have an alternative implementation with less (not zero, just less) API impact at https://github.com/bytecodealliance/wasmtime/pull/3319. I'm currently favoring that one despite it being slightly slower in benchmarks because there's still so much movement of
Val
values, but I'm not sure that this new API added here is really worth it.
alexcrichton commented on issue #3298:
I'm going to close this because I don't think that this is the best way to optimize this, it futzes with too many APIs and will be annoying to maintain I think.
Last updated: Dec 23 2024 at 12:05 UTC