Stream: git-wasmtime

Topic: wasmtime / issue #3291 Refactor the internals of `Store<T>`


view this post on Zulip Wasmtime GitHub notifications bot (Sep 03 2021 at 15:08):

alexcrichton commented on issue #3291:

It's worth pointing out that one refactoring I actually tried out was "what if we used Pin<Box<StoreInner<T>>>? I actually got pretty far with this but there's a few reasons that I didn't commit to it:

So basically the ergonomic drop plus not actually providing much benefit led me to the conclusion that we simply need to continue to be vigilant within Wasmtime to do the right thing. We do still need the PhantomPinned, though, I think. I'm at least somewhat sure that we can't be marking all our pointers as noalias with all the aliasing we actually have...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 03 2021 at 15:40):

github-actions[bot] commented on issue #3291:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>


Last updated: Dec 23 2024 at 13:07 UTC