Wasmtime GitHub notifications bot (Aug 27 2021 at 09:39): Wasmtime GitHub notifications bot (Aug 27 2021 at 09:39):Jake-Shadle commented on issue #3255:
Actually it is better to be specific and use
1.54.0instead of stable, this will have the same problem that we saw since stable just means, "use stable as installed by rustup" which means if stable is already installed it won't update to newer versions.
Wasmtime GitHub notifications bot (Aug 27 2021 at 10:17):bnjbvr commented on issue #3255:
Ok, so the CI steps show that having a fixed version won't do well with the nightly-only tests, so we should probably not do it that way. Another way would have to precise the rustc version in the
ci/run-tests.shscript, but if I understand correctly it would also affect nightly versions of rustc that run these tests in automation.We could have the
ci/run-script.shlook at an env variable that specifies which Rustc version it should use, or use a default rustc version (latest rustc stable, defined as a specific version number per @Jake-Shadle 's point), and specify this version in thecargoinvokation. It's a bit annoying as it means that we'd need to manually bump the version number in there every time a new stable rustc is released.Any thoughts about this, or any other ideas for supporting this?
Wasmtime GitHub notifications bot (Aug 27 2021 at 16:00):alexcrichton commented on issue #3255:
Is it possible to mirror what this repo's CI does and
rustup update stableat the beginning of each CI job? Personally I've always felt that arust-toolchainfile is quite heavy-handed for these purposes and would prefer to not have one since it prevents easy experiementation with other versions.
Wasmtime GitHub notifications bot (Aug 30 2021 at 08:58):bnjbvr commented on issue #3255:
Yep, this sounds simpler. Thanks for taking a look, though!
Last updated: Nov 22 2024 at 16:03 UTC