Wasmtime GitHub notifications bot (Aug 25 2021 at 16:27): Wasmtime GitHub notifications bot (Aug 25 2021 at 16:27):alexcrichton commented on issue #3242:
Oh dear it appears that these assertions are actually tripping on CI. @cfallin could you help investigate these? Alternatively I'm still learning the intricacies of
MachBufferso I can take a look later too
Wasmtime GitHub notifications bot (Aug 25 2021 at 19:04):cfallin commented on issue #3242:
@alexcrichton I'll take a look!
Wasmtime GitHub notifications bot (Aug 25 2021 at 20:02):cfallin commented on issue #3242:
@alexcrichton this seems to fix it: https://github.com/cfallin/wasmtime/commit/31014599798604ecd82de02162755673d1bf3c84 Feel free to pull that into this PR!
Basically, we were (i) checking invariants too often, including when they are temporarily violated (as per design), and (ii) not quite checking one of the invariants right, specifically by not skipping checks on labels that have been aliased away.
Wasmtime GitHub notifications bot (Aug 25 2021 at 20:02):cfallin commented on issue #3242:
(Thanks for finding this, by the way; I probably never would have noticed the
cfg(debug)double-checking code not actually running!)
Last updated: Nov 22 2024 at 16:03 UTC