Stream: git-wasmtime

Topic: wasmtime / issue #3236 Don't parse symbol names allocatin...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2021 at 15:50):

github-actions[bot] commented on issue #3236:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Aug 25 2021 at 19:33):

alexcrichton commented on issue #3236:

I don't think the object crate gives us access to what the symbol's index will be ahead of time (sort of rightully so I think). That being said all we need is the offset/size of each symbol within the text section, so I think that's pretty reasonable to encode in FunctionInfo. I'll look to do that to avoid having to match up against symbol names, and I don't think that will take too long to decode when we load a module.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2021 at 03:52):

alexcrichton commented on issue #3236:

Ok the route from this at this point is diverging very heavily from this PR, so I'll reopen after some other refactorings have gone in.

Last updated: Oct 23 2024 at 20:03 UTC