Wasmtime GitHub notifications bot (Aug 18 2021 at 22:17): Wasmtime GitHub notifications bot (Aug 18 2021 at 22:17):jlb6740 commented on issue #3209:
Assertion was unnecessary and incorrect. It assumed input types had to align with a very specific Wasm instruction which is not the right thing to do.
Wasmtime GitHub notifications bot (Aug 18 2021 at 22:18):jlb6740 commented on issue #3209:
fix for #3161
Wasmtime GitHub notifications bot (Aug 18 2021 at 22:28):jlb6740 commented on issue #3209:
Also seems to fix #3160
Wasmtime GitHub notifications bot (Aug 24 2021 at 05:25):jlb6740 commented on issue #3209:
Thanks @alexcrichton. This really just needed refactoring to avoid entering prematurely the branch that implements F64x2ConvertLowI32x4U. Above is a fix .. hopefully nothing is amiss.
Wasmtime GitHub notifications bot (Aug 24 2021 at 14:48):alexcrichton commented on issue #3209:
I'll defer to @cfallin's review of the code here, I'm not super familiar with the x64 backend myself
(although I do think it would be good to add some tests)
Wasmtime GitHub notifications bot (Aug 26 2021 at 17:07):jlb6740 commented on issue #3209:
This looks good to me now -- thanks for bearing with us through all the discussion!
No, thank you. Simply needed to refactor after interpreting correctly what the bug was saying. Highlights the need for fuzz testing when lowering becomes branchy.
Wasmtime GitHub notifications bot (Aug 26 2021 at 17:07):jlb6740 edited a comment on issue #3209:
This looks good to me now -- thanks for bearing with us through all the discussion!
@cfallin No, thank you. Simply needed to refactor after interpreting correctly what the bug was saying. Highlights the need for fuzz testing when lowering becomes branchy.
Last updated: Oct 23 2024 at 20:03 UTC