alexcrichton commented on issue #3196:
As a heads up there's a ton of non-obvious code movement in this PR. While it can be reviewed in detail the diff is quite large. It was not my intention to actually modify any behavior in this PR, this should in theory be only a large refactoring.
bjorn3 commented on issue #3196:
Does Spidermonkey need this function?
bjorn3 edited a comment on issue #3196:
Does Spidermonkey need this?
bjorn3 edited a comment on issue #3196:
Does Spidermonkey need the module translation code too? Or does it write its own code?
cfallin commented on issue #3196:
Does Spidermonkey need the module translation code too? Or does it write its own code?
SpiderMonkey only uses the per-function translation API surface, so AFAIK this should not break it. The relevant code is here; see e.g. how
BatchCompiler
holds aFuncTranslator
but not anything at the module level.
cfallin edited a comment on issue #3196:
Does Spidermonkey need the module translation code too? Or does it write its own code?
SpiderMonkey only uses the per-function translation API surface, so AFAIK this should not break it. The relevant code is here; see e.g. how
BatchCompiler
holds aFuncTranslator
but not anything at the module level (edit: or at least, not the module translator).
pchickey commented on issue #3196:
Lucet also uses
ModuleEnvironment
, so we will need to inline the implementation over there so that we can keep on putting cranelift bugfixes into Lucet.
alexcrichton commented on issue #3196:
@pchickey would you prefer if I just left
cranelift-wasm
alone in this regard? I could still inline everything intowasmtime-environ
and just leave the crate alone and achieve the same goals here.
pchickey commented on issue #3196:
Yeah, that should be fine for now. We can add a deprecation warning for now, and delete the dead code in
cranelift-wasm
in a little while after lucet is finally dead
alexcrichton commented on issue #3196:
Ok I've updated to avoid changing
cranelift-wasm
and I've updated the commit/PR description as well.
alexcrichton commented on issue #3196:
One worthwhile thing to point out is that with Wasmtime no longer using
translate_module
I think that means that there will be no more active maintainers of that functionality incranelift-wasm
any more.
Last updated: Dec 23 2024 at 12:05 UTC