Stream: git-wasmtime

Topic: wasmtime / issue #3188 Implement `Extractlane`, `UaddSat`...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 11:04):

afonso360 commented on issue #3188:

Thanks for filing the issue!

Could you add a simd- prefix to the test file names? Just to keep in line with the other tests on that directory.

Otherwise LGTM! Thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 18 2021 at 11:15):

afonso360 edited a comment on issue #3188:

Thanks for filing the issue!

Could you add a simd- prefix to the test file names? Just to keep in line with the other tests on that directory.

Otherwise LGTM! Thank you!

Edit: The CI Failure is a known flaky test, should go away when someone re runs the CI pipeline

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2021 at 04:10):

cfallin commented on issue #3188:

There's a cargo-deny issue that I think you'll need to rebase over #3227 to fix; once you've done that, then I'm happy to merge.

Last updated: Oct 23 2024 at 20:03 UTC