Stream: git-wasmtime

Topic: wasmtime / issue #3140 fuzz: log WebAssembly modules to f...

Wasmtime GitHub notifications bot (Aug 03 2021 at 23:27):

abrown opened issue #3140:

@alexcrichton suggested moving to use log_wasm to output the contents of fuzzed WebAssembly modules instead of printing them to stdout or log::debug as is done currently. There are some advantages to doing this, mainly it is very convenient to run the Wasm file in wasmtime directly or upload it somewhere. Any opinions on this, @fitzgen? If we all agree then I will do this refactoring after #3124 is resolved.

Wasmtime GitHub notifications bot (Aug 04 2021 at 00:34):

fitzgen commented on issue #3140:

I would only add that this should only be done when debug logging is enabled, so that we aren't doing a bunch of file I/O on every iteration by default.

Wasmtime GitHub notifications bot (Aug 04 2021 at 00:52):

abrown commented on issue #3140:

Yeah, that's a good point. I also saw a few cases in there where we log when something goes wrong--should we do both?

Wasmtime GitHub notifications bot (Aug 04 2021 at 20:31):

fitzgen commented on issue #3140:

Yeah, we just want to make sure not to do any file I/O on the typical, error-free paths.

Wasmtime GitHub notifications bot (Aug 11 2021 at 16:10):

abrown closed issue #3140:

@alexcrichton suggested moving to use log_wasm to output the contents of fuzzed WebAssembly modules instead of printing them to stdout or log::debug as is done currently. There are some advantages to doing this, mainly it is very convenient to run the Wasm file in wasmtime directly or upload it somewhere. Any opinions on this, @fitzgen? If we all agree then I will do this refactoring after #3124 is resolved.

Last updated: Nov 22 2024 at 17:03 UTC