abrown commented on issue #3131:
For the record, I'm not sure this would go away with the old backend (the meta crate still generates all of the CLIF instruction code) but this failure was causing too many CI failures so I think this is a good change. I'm looking right now to see if perhaps that field can be completely removed... but it seems strange that it could.
bjorn3 commented on issue #3131:
The new backends don't use ISA specific instruction and even if they would, this field is only necessary for binemit and legalization generation I think.
jlb6740 commented on issue #3131:
Is it known what dependency changed (or what merge) introduced the failure? There was a patch in TargetIsa that removed the field. The failure seemed to not be caused by any patch submission into this repository.
bjorn3 commented on issue #3131:
This was a new rustc lint in 1.54. I have been seeing it myself for a while on nightly with cg_clif.
Last updated: Dec 23 2024 at 13:07 UTC