Stream: git-wasmtime

Topic: wasmtime / issue #3115 Implement fmin_pseudo and fmax_pse...

Wasmtime GitHub notifications bot (Jul 26 2021 at 17:58):

cfallin commented on issue #3115:

Would you mind adding tests (probably runtests, constrain to x64-only for now unless aarch64 happens to support this already)?

Wasmtime GitHub notifications bot (Jul 27 2021 at 10:01):

bjorn3 commented on issue #3115:

There don't seem to be any tests for fmin_pseudo and fmax_pseudo at all.

Wasmtime GitHub notifications bot (Jul 27 2021 at 16:05):

cfallin commented on issue #3115:

There don't seem to be any tests for fmin_pseudo and fmax_pseudo at all.

Yes, exactly; no better reason than that to add some (and thanks!) :-) It's odd that the vector variants don't have tests; you could either add that too if it's not too much work, or just leave it for another PR (maybe file an issue?) otherwise.

The PR at WebAssembly/simd#122, referenced in the instructions' description text, has some examples of how pseudo-min/pseudo-max differ from true min/max, specifically w.r.t. NaNs and signed zeroes. I think it makes sense to add a test with a few input tuples from those examples, along with some more ordinary cases.

Wasmtime GitHub notifications bot (Aug 27 2021 at 15:01):

bjorn3 commented on issue #3115:

preopt.serialized got accidentally added by one PR and changed by another. It should probably be added to .gitignore.

Last updated: Oct 23 2024 at 20:03 UTC