Stream: git-wasmtime

Topic: wasmtime / issue #3093 A bit of inconsistency in the WASI...

Wasmtime GitHub notifications bot (Jul 17 2021 at 17:39):

TheLeonsver1 opened issue #3093:

In here: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md

In the C version you have
fprintf(stderr, "usage: %s <from> <to>\n", argv[0]);

In the Rust version you have
eprintln!("usage: {} <input_file> <output_file>", program);

In this section: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#executing-in-wasmtime-runtime you are showing the output of the C version which isn't the same as the output of the Rust version.
It is a minor issue but people looking only at the Rust code could be confused as to why the output is not what they expect.

Wasmtime GitHub notifications bot (Jul 17 2021 at 17:39):

TheLeonsver1 edited issue #3093:

In here: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md

In the C version you have
fprintf(stderr, "usage: %s <from> <to>\n", argv[0]);

In the Rust version you have
eprintln!("usage: {} <input_file> <output_file>", program);

In this section: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#executing-in-wasmtime-runtime you are showing the output of the C version, which isn't the same as the output of the Rust version.
It is a minor issue but people looking only at the Rust code could be confused as to why the output is not what they expect.

Wasmtime GitHub notifications bot (Jul 17 2021 at 17:41):

TheLeonsver1 edited issue #3093:

In here: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md

In the C version you have
fprintf(stderr, "usage: %s <from> <to>\n", argv[0]);

In the Rust version you have
eprintln!("usage: {} <input_file> <output_file>", program);

In this section: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#executing-in-wasmtime-runtime you are showing the output of the C version, which isn't the same as the output of the Rust version(input_file vs from and output_file vs to.
It is a minor issue but people looking only at the Rust code could be confused as to why the output is not what they expect.

Wasmtime GitHub notifications bot (Jul 17 2021 at 17:41):

TheLeonsver1 edited issue #3093:

In here: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md

In the C version you have
fprintf(stderr, "usage: %s <from> <to>\n", argv[0]);

In the Rust version you have
eprintln!("usage: {} <input_file> <output_file>", program);

In this section: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#executing-in-wasmtime-runtime you are showing the output of the C version, which isn't the same as the output of the Rust version(input_file vs from and output_file vs to).
It is a minor issue but people looking only at the Rust code could be confused as to why the output is not what they expect.

Wasmtime GitHub notifications bot (Jul 19 2021 at 20:04):

alexcrichton closed issue #3093:

In here: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md

In the C version you have
fprintf(stderr, "usage: %s <from> <to>\n", argv[0]);

In the Rust version you have
eprintln!("usage: {} <input_file> <output_file>", program);

In this section: https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-tutorial.md#executing-in-wasmtime-runtime you are showing the output of the C version, which isn't the same as the output of the Rust version(input_file vs from and output_file vs to).
It is a minor issue but people looking only at the Rust code could be confused as to why the output is not what they expect.

Wasmtime GitHub notifications bot (Jul 19 2021 at 20:45):

pchickey commented on issue #3093:

Thanks for the report, this is fixed now.

Last updated: Nov 22 2024 at 16:03 UTC