ulan commented on issue #3063:
@alexcrichton: please take a look
github-actions[bot] commented on issue #3063:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
ulan commented on issue #3063:
Looks good to me, thanks! This won't get tested on CI but I think it might be pretty expensive to test on CI, so that's probably ok for now. I don't think that this is changing much to cause many regressions hopefully.
Thanks! I agree. We will also keep an eye on it on our side and let you know if it breaks.
alexcrichton commented on issue #3063:
That all sounds reasonable to me, thanks again for the PR!
Last updated: Nov 22 2024 at 16:03 UTC