Wasmtime GitHub notifications bot (Jun 28 2021 at 18:18): Wasmtime GitHub notifications bot (Jun 28 2021 at 18:18):abrown commented on issue #3038:
@afonso360, just wanted to say this is shaping up to be a good contribution--nice work!
Wasmtime GitHub notifications bot (Jun 29 2021 at 13:16):github-actions[bot] commented on issue #3038:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "fuzzing"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 29 2021 at 14:55):afonso360 commented on issue #3038:
@cfallin Thanks for taking the time to review this!
I think that we'll want to outline the next steps, maybe even in a centralized TODO comment
I think it would be good to have a tracking issue for this so that we could also keep the discussion there. (I can open one if so)
Besides the steps that you mentioned here, we should add the TODO's that were left pending from this PR, namely:
- Deriving the instructions to be generated from
cranelift-meta- Reconsider if we want to catch traps and ensure that they produce the same trap both on the interpreter and the host. (As @cfallin points out this is probably more effort than its worth)
Wasmtime GitHub notifications bot (Jul 01 2021 at 10:59):afonso360 commented on issue #3038:
It should be ok to merge now. I've disabled publishing the
fuzzgencrate, as we do with thewasmtime-fuzzingcrate. If someone finds it useful in the future, we can always change it.Thanks to everyone for reviewing and discussing this! :tada:
Last updated: Dec 23 2024 at 12:05 UTC