Wasmtime GitHub notifications bot (Jul 30 2021 at 04:16): Wasmtime GitHub notifications bot (Jul 30 2021 at 04:16):jlb6740 commented on issue #3031:
This is a refactoring based on comments. The lowering remains intact it is just that now the clif instruction operands are more instructions. Matching in lowering is now different to properly match on the WASM instruction we are intending to lower.
The CI failures appear to be from an unrelated issue. Wish I new how to resolve but I can see a stoppage on a dead code warning.
This should be the last PR for full x64 Wasm SIMD support. Of course there are some refactoring and clean-up TODOs that should be done as follow-up.
Wasmtime GitHub notifications bot (Jul 30 2021 at 04:17):jlb6740 edited a comment on issue #3031:
This is a refactoring based on earlier comments. The lowering remains intact it is just that now the clif instruction operands are more instructions. Matching in lowering is now different to properly match on the WASM instruction we are intending to lower.
The CI failures appear to be from an unrelated issue. Wish I knew how to resolve but I can see a stoppage on a dead code warning?
This should be the last PR for full x64 Wasm SIMD support. Of course there are some refactoring and clean-up TODOs that should be done as follow-up.
Wasmtime GitHub notifications bot (Jul 30 2021 at 04:19):jlb6740 edited a comment on issue #3031:
This is a refactoring based on earlier comments. The lowering remains intact it is just that now the clif instruction operands are more instructions. Matching in lowering is now different to properly match on the WASM instruction we are intending to lower.
The CI failures appear to be from an unrelated issue. Wish I knew how to resolve but I can see a stoppage on a dead code warning?
#3123 This should be the last PR for full x64 Wasm SIMD support. Of course there are some refactoring and clean-up TODOs that should be done as follow-up.
Wasmtime GitHub notifications bot (Jul 30 2021 at 19:59):jlb6740 commented on issue #3031:
I personally wouldn't rely only on the conformance test suite, we've already had problems with it. Pretty sure you've got some bugs here and I guess the existing test suite isn't exercising them.
Hi @sparker-arm .. I was planning to check/compare the lowering after comments from this first update, but do you see something specifically in case I miss it? I agree, the spec tests have shown to sometimes be cut-n-paste exercises that aren't thoughtful for the specific instructions. Not sure the best way to provide an answer key though for this lowering sequence. The lowering is not derived by me, but it's based on the discussion during instruction proposal and cross checked against what v8 appears to be doing, and finally of course spec tests which is there to catch errors though it is not fool-proof.
Wasmtime GitHub notifications bot (Jul 30 2021 at 19:59):jlb6740 edited a comment on issue #3031:
I personally wouldn't rely only on the conformance test suite, we've already had problems with it. Pretty sure you've got some bugs here and I guess the existing test suite isn't exercising them.
Hi @sparker-arm .. I was planning to check/compare the lowering after comments from this first update, but do you see something specifically in case I miss it? I agree, the spec tests have shown to sometimes be cut-n-paste exercises that aren't thoughtful for the specific instructions. Not sure the best way to provide an answer key though for this lowering sequence. The lowering is not derived by me, but it's based on the discussion during instruction proposal and cross checked against what v8 appears to be doing, and finally of course spec tests which is there to catch errors though it is not always successful.
Wasmtime GitHub notifications bot (Jul 31 2021 at 02:18):jlb6740 commented on issue #3031:
This is intended to be ready. If there is anything else let me know.
Last updated: Dec 23 2024 at 12:05 UTC