Stream: git-wasmtime

Topic: wasmtime / issue #2983 Calling `Caller::get_export` alloc...

Wasmtime GitHub notifications bot (Jun 14 2021 at 15:38):

alexcrichton opened issue #2983:

The Caller::get_export API, which we recommend callees use to get access to memories and functions, internally allocates memory on the memory/function vectors within a store. This memory, however, cannot be deallocated until after the Store is itself deallocated. This means that each time get_export is called, which is typically handled by wasm itself, memory usage keeps growing.

We should instead have some sort of map where the same export, when fetched, always returns the same index within the Store.

Wasmtime GitHub notifications bot (Jun 14 2021 at 15:39):

alexcrichton labeled issue #2983:

The Caller::get_export API, which we recommend callees use to get access to memories and functions, internally allocates memory on the memory/function vectors within a store. This memory, however, cannot be deallocated until after the Store is itself deallocated. This means that each time get_export is called, which is typically handled by wasm itself, memory usage keeps growing.

We should instead have some sort of map where the same export, when fetched, always returns the same index within the Store.

Wasmtime GitHub notifications bot (Jun 14 2021 at 15:45):

github-actions[bot] commented on issue #2983:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 17 2021 at 19:27):

alexcrichton closed issue #2983:

The Caller::get_export API, which we recommend callees use to get access to memories and functions, internally allocates memory on the memory/function vectors within a store. This memory, however, cannot be deallocated until after the Store is itself deallocated. This means that each time get_export is called, which is typically handled by wasm itself, memory usage keeps growing.

We should instead have some sort of map where the same export, when fetched, always returns the same index within the Store.

Last updated: Dec 23 2024 at 13:07 UTC