Stream: git-wasmtime

Topic: wasmtime / issue #2969 wasmtime-cache: Update zstd

view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2021 at 16:47):

olivierlemasle commented on issue #2969:

CI fails in "verify-publish" because cargo vendor copies crate zstd-sys without its submodule. For a reason I don't understand, the crate contains zstd/lib, however when using cargo install, the zstd directory is not copied...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 07 2021 at 14:19):

alexcrichton commented on issue #2969:

I dug in a bit and I believe this is a bug in Cargo. For now the best fix though is to probably send a PR to zstd-sys to update the exclude directive to work in a way both for publication and vendoring. Unfortunately I don't think we can land this as-is until CI is green again.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 07 2021 at 14:24):

olivierlemasle commented on issue #2969:

Thank you for your analysis @alexcrichton. I was actually also looking at this list_files function...

Unfortunately I don't think we can land this as-is until CI is green again.

Of course! I'll mark this PR as a draft in the meantime.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 10 2021 at 17:47):

alexcrichton commented on issue #2969:

Thanks again!

Last updated: Dec 23 2024 at 12:05 UTC