Stream: git-wasmtime

Topic: wasmtime / issue #2961 Use the host's target ISA in the f...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2021 at 20:34):

bjorn3 commented on issue #2961:

This is only correct for 64bit systems using the SystemV call conv as default.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2021 at 22:20):

abrown commented on issue #2961:

This is only correct for 64bit systems using the SystemV call conv as default.

Yup. How is the current #[cfg_attr(not(target_arch = "x86_64"), ignore)] correct, though? When run on a non-SystemV-OS, I would guess the test should run into similar calling convention errors...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2021 at 07:54):

bjorn3 commented on issue #2961:

Previously plain x86_64 was used as target, which always defaults to SystemV. After this change the OS is also included, which can override the default calling convention. An alternative to this PR would be to add a dev-dependency on cranelift-codegen to cranelift-frontend with the x86_64 backend enabled.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2021 at 10:01):

bjorn3 commented on issue #2961:

A final suggestion would be to manually construct a specific FrontendConfig value and then avoid TargetIsa completely.

Last updated: Dec 23 2024 at 13:07 UTC