Wasmtime GitHub notifications bot (Aug 24 2021 at 11:34): Wasmtime GitHub notifications bot (Aug 24 2021 at 11:34):akirilov-arm commented on issue #2960:
@cfallin It looks like doing this optimization in the x64 backend fails on macOS. I am unable to work on this, so would it be acceptable to submit just the AArch64 part?
Wasmtime GitHub notifications bot (Aug 26 2021 at 16:45):akirilov-arm commented on issue #2960:
@cfallin Thanks for the review! I just reverted the x64 changes, but left the commit in the history in case anyone else would like to use it as a starting point in the future.
Wasmtime GitHub notifications bot (Aug 26 2021 at 17:30):bnjbvr commented on issue #2960:
Will check first thing tomorrow!
Wasmtime GitHub notifications bot (Aug 27 2021 at 10:11):bnjbvr commented on issue #2960:
Unfortunately can't check because of https://github.com/bytecodealliance/wasmtime/issues/3256 (wasmtime testing on aarch64-darwin is busted before your PR), so let's not block it on that, and merge this one; we can get back to it later. Thanks :)
Last updated: Dec 23 2024 at 12:05 UTC