Stream: git-wasmtime

Topic: wasmtime / issue #2953 Cranelift: Add `LibCall::Memcmp`

Wasmtime GitHub notifications bot (May 31 2021 at 19:32):

bjorn3 commented on issue #2953:

Could you also add a call_memcpy and maybe emit_small_memcpy to cranelift_frontend just like memcpy and memmove? https://github.com/bytecodealliance/wasmtime/blob/40d546c420c1e6c4909fc80e048dd1854fda1cd6/cranelift/frontend/src/frontend.rs#L601

Wasmtime GitHub notifications bot (May 31 2021 at 19:33):

bjorn3 edited a comment on issue #2953:

Could you also add an emit_small_memcpy to cranelift_frontend?

Wasmtime GitHub notifications bot (May 31 2021 at 19:34):

bjorn3 edited a comment on issue #2953:

Could you also add an emit_small_memcmp to cranelift_frontend?

Wasmtime GitHub notifications bot (May 31 2021 at 19:44):

scottmcm commented on issue #2953:

@bjorn3 Wow you're fast :smile:

I'm not sure how to emit anything nice in emit_small_memcmp, because it's a big-endian comparison. (I guess that's something to add to the todo list once https://github.com/bytecodealliance/wasmtime/issues/1092 happens.)

I could add emit_small_mem_eq and emit_small_mem_ne, if those would be worth it?

Wasmtime GitHub notifications bot (May 31 2021 at 19:45):

bjorn3 commented on issue #2953:

I guess you can leave it as is for now.

Last updated: Dec 23 2024 at 12:05 UTC