Wasmtime GitHub notifications bot (May 27 2021 at 23:40): Wasmtime GitHub notifications bot (May 27 2021 at 23:40):github-actions[bot] commented on issue #2946:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 28 2021 at 13:15):peterhuene commented on issue #2946:
I think this might need to be rebased on main.
Wasmtime GitHub notifications bot (May 28 2021 at 13:24):peterhuene commented on issue #2946:
Erm, never mind, I forgot we hadn't merged in the API changes yet, which this is based on.
Wasmtime GitHub notifications bot (May 28 2021 at 13:24):peterhuene edited a comment on issue #2946:
I think this might need to be rebased on main.
Wasmtime GitHub notifications bot (Jun 03 2021 at 22:19):pchickey commented on issue #2946:
That is understandable. We haven't measured, and I don't think signal handler installation takes especially long, but we wanted this functionality so that we could eliminate the possibility from any sort of performance issue we hit at runtime, or debugging any sort of interaction with other parts of the process that install signal handlers.
I don't feel extremely strongly about this but @acfoltzer advocated for it, and my judgement was the trouble it might save us debugging one day is worth exposing this implementation detail.
Wasmtime GitHub notifications bot (Jun 03 2021 at 23:16):github-actions[bot] commented on issue #2946:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 04 2021 at 14:15):alexcrichton commented on issue #2946:
Ok, in any case it's a relatively small API and not super hard to support. Could you expand the documentation with some possible use cases though? I'd also prefer if the tokio example didn't get updated to use it because it feels like it's mostly just boilerplate for most use cases and not all that necessary. (although having this in a test seems good)
Wasmtime GitHub notifications bot (Jun 04 2021 at 21:22):pchickey commented on issue #2946:
yep they were staged in git and i committed wrong.
Last updated: Dec 23 2024 at 13:07 UTC