cfallin commented on issue #2898:
+1 to @bnjbvr's suggestion -- the lowering code for these instructions in the ARM backends should go away. I think that when I wrote it for aarch64 I just wasn't aware of the vector-only history; cool that it was supported but less code is always better from a maintenance perspective, especially if it is now dead code!
abrown commented on issue #2898:
@fitzgen, I am assuming peepmatic had to be updated because of the cranelift/meta changes but correct me if I did something wrong: I simply ran
cargo test --features 'enable-peepmatic rebuild-peephole-optimizers' peepmatic
and committed the results.
fitzgen commented on issue #2898:
@fitzgen, I am assuming peepmatic had to be updated because of the cranelift/meta changes but correct me if I did something wrong: I simply ran
cargo test --features 'enable-peepmatic rebuild-peephole-optimizers' peepmatic
and committed the results.That sounds correct :+1:
Last updated: Dec 23 2024 at 12:05 UTC