Wasmtime GitHub notifications bot (Oct 01 2021 at 20:58): Wasmtime GitHub notifications bot (Oct 01 2021 at 20:58):akirilov-arm commented on issue #2844:
Obsoleted by #3009?
Wasmtime GitHub notifications bot (Oct 01 2021 at 21:01):cfallin commented on issue #2844:
Indeed!
Wasmtime GitHub notifications bot (Oct 01 2021 at 21:01):cfallin closed issue #2844:
Thanks to a collaborative debugging session with @alexcrichton, we've identified what the issue was with my test case failing on Windows: it was a combination of using the old-backend (before the type-confusion bug had been fixed) and Windows, following #2806 that broke unwind information generation on windows old-backend (I'll send a PR for this).
So the real question is, should we re-add the CI on Windows for support of the old-backend?
- If the plan is to remove the old-backend before the next release, that means that it won't be available later, so there's not a real point in maintaining it.
- If the plan is to remove the old-backend after the next release, then it'd be nice to not break it in the future, and in this case it would be worthwhile adding it back in CI, in my opinion.
Last updated: Nov 22 2024 at 17:03 UTC