Stream: git-wasmtime

Topic: wasmtime / issue #2808 Can't unwind wasm frames on aarch6...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 11:19):

akirilov-arm commented on issue #2808:

@bnjbvr @cfallin @fitzgen Is this issue still relevant? It affects the tests in tests/all/traps.rs in particular.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2022 at 16:30):

fitzgen commented on issue #2808:

This is probably still relevant for when we emit unwind info, which is a configuration we still want to support to integrate with external tools like GDB/profilers/etc, but it is no longer an issue that is critical for correctness (e.g. reclaiming GC garbage).

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 13:25):

bnjbvr commented on issue #2808:

This is also used to compute backtraces, right? I'll note to try it again on my side.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2022 at 17:10):

fitzgen commented on issue #2808:

Backtraces are now captured by walking frame pointers since https://github.com/bytecodealliance/wasmtime/pull/4431

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2022 at 14:24):

bnjbvr commented on issue #2808:

Very sweet! I've just retried on my mac m1, and indeed these tests now pass after uncommenting the cfg_attr (I'll submit a PR), and in our embedding I can see a full stack trace \o/
Thanks @fitzgen for working on this!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2022 at 17:35):

akirilov-arm commented on issue #2808:

FYI recently I did a little investigation for my back-edge CFI work, and the only remaining user I could find of the backtrace crate, and by extension the system unwinder, is the wasmtime-fiber crate. In fact, that is just a test dependency, and, more precisely, only one test needs it - backtrace_traces_to_host.

Of course, there is still the issue about integrating with external tools such as debuggers.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2022 at 17:48):

fitzgen commented on issue #2808:

the only remaining user I could find of the backtrace crate, and by extension the system unwinder, is the wasmtime-fiber crate. In fact, that is just a test dependency, and, more precisely, only one test needs it - backtrace_traces_to_host.

FWIW, I think this is 100% okay. We shouldn't be concerned about dev deps in the same way we are about regular deps.

Of course, there is still the issue about integrating with external tools such as debuggers.

We do still emit native unwind info by default, but also have a wasmtime::Config knob to turn it off should an embedder choose to.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2022 at 17:50):

fitzgen commented on issue #2808:

Can we close this issue now? @bnjbvr I can't remember: did you submit the PR you mentioned you'd make in https://github.com/bytecodealliance/wasmtime/issues/2808#issuecomment-1212060039? I don't see any cfg_attr in tests/all/traps.rs anymore so I assume so.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2022 at 19:40):

bnjbvr commented on issue #2808:

Yep, I did submit this PR, so we could consider this closed. I didn't link this issue in the PR because the native unwinders would still require this to work properly, but maybe that can be deferred to a future issue.

Last updated: Nov 22 2024 at 17:03 UTC