cfallin edited issue #2467 (assigned to jlb6740):
I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using
ROUNDSD
andROUNDSS
--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version..._Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_
cfallin labeled issue #2467 (assigned to jlb6740):
I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using
ROUNDSD
andROUNDSS
--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version..._Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_
alexcrichton closed issue #2467:
I know this isn't part of the PR, but it is curious that these are implemented as lib calls instead of using
ROUNDSD
andROUNDSS
--@bnjbvr, do you know why this is? I wonder if there is some NaN handling there that we should also be doing for the packed version..._Originally posted by @abrown in https://github.com/bytecodealliance/wasmtime/pull/2457#discussion_r534339371_
alexcrichton commented on issue #2467:
I believe that this has since been handled, so closing.
Last updated: Dec 23 2024 at 12:05 UTC