Stream: git-wasmtime

Topic: wasmtime / issue #2000 wasmtime-wiggle: optionally skip `...

Wasmtime GitHub notifications bot (Jun 16 2021 at 16:15):

pchickey commented on issue #2000:

the design of wasmtime & wiggle have changed to make this no longer an issue

Wasmtime GitHub notifications bot (Jun 16 2021 at 16:15):

pchickey closed issue #2000:

This is a good beginner issue that is scoped to the wasmtime-wiggle crate, at crates/wiggle/wasmtime.

My colleague @jedisct1 has pointed out that wasmtime_wiggle::wasmtime_integration! requires you to duplicate all of the module names in the .witx document in the arguments, e.g:

modules: { some_module => { name: SomeTypeName, docs: "That type's docstring" }

This argument was created so we could have perfect parity with the existing wig integration, but its probably more verbose than some users need. In Frank's case, it would be sufficient to just map each witx module to a CamelCased Rust name, and elide any docs.

I propose that we make the modules argument to wasmtime_integration! optional. When it is provided, it should work as today, and when it is missing, it should instead generate a module for each the witx Document::modules().

Last updated: Oct 23 2024 at 20:03 UTC