Stream: git-wasmtime

Topic: wasmtime / issue #1919 wasmtime-wiggle: add small integra...

Wasmtime GitHub notifications bot (Jun 16 2021 at 16:14):

pchickey commented on issue #1919:

wiggle has a wasmtime_integration test these days.

Wasmtime GitHub notifications bot (Jun 16 2021 at 16:14):

pchickey closed issue #1919:

Feature

The wasmtime-wiggle crate is tested via its use in wasmtime-wasi. It does not have any tests local to the crate. We should add them.

Benefit

wasi is a very complicated interface & implementation that could make it hard to track down whether a bug is in wiggle, wasmtime-wiggle, or wasi-common. Having a integration test would help us narrow that down. It would also serve as documentation on how to use the crate.

Implementation

The wiggle crate's test suite has a number of witx files and implementations. We could add tests that show those integrated end-to-end with wasmtime to the wasmtime-wiggle crate.

We would probably have to write the WebAssembly code that exercises these apis by hand (.wat). That is less than ideal, but I believe we should avoid adding the complication of a Rust or C wasm toolchain to the testing story.

Alternatives

Yolo?

Last updated: Dec 23 2024 at 12:05 UTC