Wasmtime GitHub notifications bot (Nov 19 2021 at 18:26): Wasmtime GitHub notifications bot (Nov 19 2021 at 18:26):fitzgen commented on issue #1706:
Peepmatic was removed in https://github.com/bytecodealliance/wasmtime/pull/3543
Wasmtime GitHub notifications bot (Nov 19 2021 at 18:26):fitzgen closed issue #1706:
Right now, peepmatic has no knowledge of (for example)
iadd's commutativity, and so both of the following optimizations must be written:(=> (iadd $C $x) (iadd_imm $C $x)) (=> (iadd $x $C) (iadd_imm $C $x))We could give peepmatic knowledge of commutativity to make it so that we only had to write one or the other in the DSL.
If we did this at the automaton level, this would create extra states (but I guess we have those states anyways if we repeat the optimization definitions).
If we did this at the interpreter level, this would not create extra states, but would involve extra runtime checking. It would also be incompatible with #1704
Last updated: Oct 23 2024 at 20:03 UTC