Stream: git-wasmtime

Topic: wasmtime / issue #12159 Outdated comment for `ValueRegs`


view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2025 at 21:33):

MilkeeyCat opened issue #12159:

https://github.com/bytecodealliance/wasmtime/blob/05a711f6ff5317bbc5b5268a05543719f96482d5/cranelift/codegen/src/machinst/valueregs.rs#L19-L20

It was true when this file was created in https://github.com/bytecodealliance/wasmtime/commit/6eea015d6c512882e426ffc670b180a971afad05 but after ARM32 backend removal(https://github.com/bytecodealliance/wasmtime/commit/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab) VALUE_REGS_PARTS is always equal to 2.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2025 at 00:58):

cfallin commented on issue #12159:

PR welcome to fix this, if you'd like -- I'd be happy to review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2025 at 07:07):

MilkeeyCat commented on issue #12159:

Would you like "we cap the capacity of this at four (when any 32-bit target is enabled) or two (otherwise)" part to be removed or changed to something else?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2025 at 08:19):

cfallin closed issue #12159:

https://github.com/bytecodealliance/wasmtime/blob/05a711f6ff5317bbc5b5268a05543719f96482d5/cranelift/codegen/src/machinst/valueregs.rs#L19-L20

It was true when this file was created in https://github.com/bytecodealliance/wasmtime/commit/6eea015d6c512882e426ffc670b180a971afad05 but after ARM32 backend removal(https://github.com/bytecodealliance/wasmtime/commit/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab) VALUE_REGS_PARTS is always equal to 2.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2025 at 08:19):

cfallin commented on issue #12159:

Hmm, reading a bit more context now, since you're asking -- I actually think it's fine to leave as-is. It's vacuously true that the capacity of ValueRegs is four registers on targets with only 32-bit registers, because we have no such targets; but more importantly it documents the intent, which is that it should always have capacity for 128 bits. Not really worth bikeshedding better text here IMHO. I'll go ahead and close this issue but thanks for raising it!


Last updated: Dec 13 2025 at 19:03 UTC