Stream: git-wasmtime

Topic: wasmtime / issue #11573 Cranelift's `Function::is_leaf` d...

Wasmtime GitHub notifications bot (Aug 29 2025 at 21:14):

alexcrichton opened issue #11573:

Currently is_leaf affects whether frame pointers are used at the ABI layer. The implementation of this function, however, just checks if there's no signatures or tls variables. This is inaccurate for a few reasons:

1. A signature might be present to return the address of a function, not necessarily to call the signature.
2. A function may have no signatures or TLS variables but still invoke a libcall.

We'll probably want to scan the VCode for calls to determine if something is a leaf or not.

Wasmtime GitHub notifications bot (Aug 29 2025 at 21:14):

alexcrichton added the bug label to Issue #11573.

Wasmtime GitHub notifications bot (Aug 29 2025 at 21:14):

alexcrichton added the cranelift label to Issue #11573.

Wasmtime GitHub notifications bot (Aug 29 2025 at 21:32):

pchickey edited issue #11573:

Currently is_leaf affects whether frame pointers are used at the ABI layer. The implementation of this function, however, just checks if there's no signatures or tls variables. This is inaccurate for a few reasons:

1. A signature might be present to return the address of a function, not necessarily to call the signature.
2. A function may have no signatures or TLS variables but still invoke a libcall.

We'll probably want to scan the VCode for calls to determine if something is a leaf or not.

Wasmtime GitHub notifications bot (Sep 03 2025 at 16:20):

cfallin closed issue #11573:

Currently is_leaf affects whether frame pointers are used at the ABI layer. The implementation of this function, however, just checks if there's no signatures or tls variables. This is inaccurate for a few reasons:

1. A signature might be present to return the address of a function, not necessarily to call the signature.
2. A function may have no signatures or TLS variables but still invoke a libcall.

We'll probably want to scan the VCode for calls to determine if something is a leaf or not.

Last updated: Dec 06 2025 at 06:05 UTC