Stream: git-wasmtime

Topic: wasmtime / issue #1144 Integrate clippy checking in CI build

Wasmtime GitHub notifications bot (May 10 2024 at 02:22):

alexcrichton closed issue #1144:

Please try to describe precisely what you would like to do in Cranelift and/or
expect from it. You can answer the questions below if they're relevant and
delete this text before submitting. Thanks for opening an issue!

• What is the feature or code improvement you would like to do in Cranelift?
  After merging bytecodealliance/cranelift#1169 (and seeing bytecodealliance/cranelift#1168), it occurred to me that we should output clippy warnings as a part of test-all.sh. I'm not sure we should fail the build (though this could be an option) but this would make non-clippy-approved additions more visible.

• What is the value of adding this in Cranelift?
  It should result in cleaner, more standard code in the long run.

• Do you have an implementation plan, and/or ideas for data structures or
  algorithms to use?
  Add cargo clippy to test-all.sh and ensure clippy is installed for Azure pipelines.

• Have you considered alternative implementations? If so, how are they better
  or worse than your proposal?
  No.
  

Wasmtime GitHub notifications bot (May 10 2024 at 02:22):

alexcrichton commented on issue #1144:

Clippy is currently checked on CI although most lints are turned off. It's intended that we'll enable clippy lints on a case-by-case basis and watch them in CI.

Last updated: Dec 23 2024 at 13:07 UTC