Stream: git-wasmtime

Topic: wasmtime / issue #1143 Rename the stack_load / stack_stor...

Wasmtime GitHub notifications bot (May 04 2022 at 23:08):

cfallin commented on issue #1143:

No one seems to have strong opinions about this bikeshed needing to be painted a different color, and I'm cleaning up old issues, so I'm going to go ahead and close this; but, suggestions of this sort are always welcome if anyone has new ideas :-)

Wasmtime GitHub notifications bot (May 04 2022 at 23:08):

cfallin closed issue #1143:

I think the stack_load format should be renamed, as it is used for stack_addr here too.

_Originally posted by @bjorn3 in https://github.com/CraneStation/cranelift/pull/1160_

It's a good idea, but I can't think of a right name right now. Format naming can sometimes be inconsistent.

The stack_load format is used by two instructions:

• the stack_load instruction (load from the stack)
• the stack_addr instruction, which computes the address of a stack slot.

The stack_store format is used only the instruction that has the same name.

For consistency with other operators, I thought about renaming stack_load => UnaryStack, and stack_store => BinaryStack, but I feel it hides part of the information (which is why I'm not a huge fan of BinaryImm in the first place).

Maybe an alternative is to rename stack_load into stack_read, and keep stack_store as is?

(Let the bikeshed begin!)

Last updated: Nov 22 2024 at 16:03 UTC