Stream: git-wasmtime

Topic: wasmtime / issue #11091 CI Bug: wasip2 examples are not c...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2025 at 19:04):

ifsheldon opened issue #11091:

I think this breaking change from #10770 should've broken some examples in CI like https://github.com/bytecodealliance/wasmtime/tree/main/examples/wasip2-async and https://github.com/bytecodealliance/wasmtime/tree/main/examples/wasip2 but these were not checked in CI. Probably we should fix this problem by adding these examples in here?
https://github.com/bytecodealliance/wasmtime/blob/a7d9f3e114fc74889000aeb2c136e9dfd5c374be/Cargo.toml#L147

cc @alexcrichton

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2025 at 14:39):

alexcrichton commented on issue #11091:

Oops yes that's a mistake, we should build these on CI!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2025 at 18:02):

alexcrichton commented on issue #11091:

Hm actually, can you clarify what is broken? Both examples work fine for me on main?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2025 at 02:30):

ifsheldon commented on issue #11091:

Sorry. #10770 broke my example code in https://github.com/ifsheldon/wasi_mindmap, so I thought it should have broken similar code in wasmtime/examples, but it turns out the wasmtime/examples/wasip2-async and wasmtime/examples/wasip2 are too trivial to be affected, since they don't need autogenerated add_to_linker function from bindgen!.

I can add one more example to examples that is more complicated and is indeed affected by #10770 if you like.

When I checked which examples are run in CI, I did find a minor bug (#11116) related to this issue.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 24 2025 at 14:38):

alexcrichton commented on issue #11091:

Examples are always welcome! Definitely feel free to PR one if you'd like

view this post on Zulip Wasmtime GitHub notifications bot (Jun 30 2025 at 14:51):

alexcrichton closed issue #11091:

I think this breaking change from #10770 should've broken some examples in CI like https://github.com/bytecodealliance/wasmtime/tree/main/examples/wasip2-async and https://github.com/bytecodealliance/wasmtime/tree/main/examples/wasip2 but these were not checked in CI. Probably we should fix this problem by adding these examples in here?
https://github.com/bytecodealliance/wasmtime/blob/a7d9f3e114fc74889000aeb2c136e9dfd5c374be/Cargo.toml#L147

cc @alexcrichton

Last updated: Dec 06 2025 at 07:03 UTC