Stream: git-wasmtime

Topic: wasmtime / issue #1100 iadd_cout and isub_bout wrong for ...

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 20:56):

cfallin commented on issue #1100:

Closing in favor of #2860 as we need to implement the carry/borrow-out-as-flag in general (we no longer use the old legalizations).

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2022 at 20:56):

cfallin closed issue #1100:

https://github.com/CraneStation/cranelift/blob/2b1cfea1634c58d22b880eb082c748350041c3f0/cranelift-codegen/meta/src/shared/legalize.rs#L465-L477

They should do a signed comparison for signed integers.

Edit: when y is negative, the condition should be inverted too.

Last updated: Oct 23 2024 at 20:03 UTC