Stream: git-wasmtime

Topic: wasmtime / issue #10367 EntitySet does not have feature="...

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:57):

djmarcin opened issue #10367:

Feature

EntitySet does not have the following annotation, despite appearing to be mostly a wrapper around a CompoundBitSet, which does. I'm hoping this is just an oversight?

#[derive(Clone, Default, PartialEq, Eq)]
#[cfg_attr(
feature = "enable-serde",
derive(serde_derive::Serialize, serde_derive::Deserialize)
)]

Benefit

Allows EntitySet to be used in Serializable data structures like PrimaryMap/SecondaryMap/etc.

Implementation

Add the missing annotation.

Alternatives

n/a

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:58):

djmarcin edited issue #10367:

Feature

EntitySet does not have the following annotation, despite appearing to be mostly a wrapper around a CompoundBitSet, which does. I'm hoping this is just an oversight?

#[derive(Clone, Default, PartialEq, Eq)]
#[cfg_attr(
    feature = "enable-serde",
    derive(serde_derive::Serialize, serde_derive::Deserialize)
)]

Benefit

Allows EntitySet to be used in Serializable data structures like PrimaryMap/SecondaryMap/etc.

Implementation

Add the missing annotation.

Alternatives

n/a

Wasmtime GitHub notifications bot (Mar 10 2025 at 22:10):

cfallin closed issue #10367:

Feature

EntitySet does not have the following annotation, despite appearing to be mostly a wrapper around a CompoundBitSet, which does. I'm hoping this is just an oversight?

#[derive(Clone, Default, PartialEq, Eq)]
#[cfg_attr(
    feature = "enable-serde",
    derive(serde_derive::Serialize, serde_derive::Deserialize)
)]

Benefit

Allows EntitySet to be used in Serializable data structures like PrimaryMap/SecondaryMap/etc.

Implementation

Add the missing annotation.

Alternatives

n/a

Last updated: Apr 16 2025 at 22:03 UTC