Stream: git-wasmtime

Topic: wasmtime / issue #1035 Consider alternative methods for w...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 19:20):

bjorn3 commented on issue #1035:

The CodeSink trait is now gone. MachBufferFinalized contains all information in the form of SmallVec's which the user can access as slices. As such I think this issue can be closed.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 23:13):

cfallin closed issue #1035:

Currently, binemit has its own CodeSink trait for writing binary data. It isn't entirely satisfying, in part because it's an unsafe interface -- it doesn't perform bounds checking on the underlying data. While we can provide relatively safe interfaces to protect users from misusing the API, it's harder to be absolutely certain that the number of bytes compile says a function needs is the number of bytes emit_to_memory actually writes for that function.

One option would be to provide a safe checked version of MemoryCodeSink. However, it's also worth considering evaluating available crates that provide low-level byte buffer writing functionality, including:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2024 at 23:13):

cfallin commented on issue #1035:

Yep, this is no longer an issue -- thanks!

Last updated: Nov 22 2024 at 16:03 UTC