Wasmtime GitHub notifications bot (Mar 29 2022 at 17:54): Wasmtime GitHub notifications bot (Mar 29 2022 at 17:54):pchickey closed issue #1034:
I have encountered at least one bug related to instruction encodings that was pretty tricky to isolate, but easy enough to fix, https://github.com/Cretonne/cretonne/issues/211
It would be helpful to have a test suite that compared Cretonne's encodings against another toolchain (probably llvm, though gcc could work too). The meta-language could add a way to specify how to translate an instruction into assembly language text, and the encoding of the instruction could be compared against the output of another assembler. The domain size for each instruction is small enough that this could probably be an exhaustive test.
Wasmtime GitHub notifications bot (Mar 30 2022 at 12:49):bjorn3 commented on issue #1034:
Why did you close this? I don't think this is implemented yet.
Wasmtime GitHub notifications bot (Mar 30 2022 at 19:10):cfallin commented on issue #1034:
I guess @pchickey is cleaning up old issues generally... while it's true we don't test encodings specifically against other toolchains, I think we have equivalent-or-better coverage via differential fuzzing against other engines (V8, wasmi, spec interpreter). So IMHO at least I could potentially call this issue "obsolete", though others feel free to weigh in as well.
Last updated: Oct 23 2024 at 20:03 UTC