Stream: git-wasmtime

Topic: wasmtime / PR #9993 winch(x64): Fix `MemOpKind` for `i64_...

Wasmtime GitHub notifications bot (Jan 13 2025 at 13:48):

saulecabrera requested abrown for a review on PR #9993.

Wasmtime GitHub notifications bot (Jan 13 2025 at 13:48):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9993.

Wasmtime GitHub notifications bot (Jan 13 2025 at 13:48):

saulecabrera opened PR #9993 from saulecabrera:winch-fix-mem-op-kind-for-atomic-loads to bytecodealliance:main:

Change from MemOpKind::Normal to MemOpKind::Atomic. In the case of x64 this change doesn't meaningfully change the output of the instruction. However, for correctness and for the purposes of other backends, we need to pass the right MemOpKind.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 13 2025 at 15:44):

github-actions[bot] commented on PR #9993:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 13 2025 at 15:48):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 13 2025 at 17:28):

saulecabrera updated PR #9993.

Wasmtime GitHub notifications bot (Jan 13 2025 at 17:30):

saulecabrera commented on PR #9993:

The failure was due to a missing rebase.

Wasmtime GitHub notifications bot (Jan 13 2025 at 18:31):

saulecabrera merged PR #9993.

Last updated: Jan 24 2025 at 00:11 UTC