Wasmtime GitHub notifications bot (Jan 12 2025 at 19:35): Wasmtime GitHub notifications bot (Jan 12 2025 at 19:35):VolodymyrBg opened PR #9989 from VolodymyrBg:wasm to bytecodealliance:main:
Add support for parsing hexadecimal integers (prefixed with 0x or 0X) when passing arguments to WebAssembly functions. This enhancement allows users to specify integer arguments in both decimal and hexadecimal formats.
For example:
- Decimal: 42
- Hexadecimal: 0x2A or 0x2a
The change affects both i32 and i64 argument types while maintaining backward compatibility with decimal notation.
Wasmtime GitHub notifications bot (Jan 12 2025 at 19:35):VolodymyrBg requested fitzgen for a review on PR #9989.
Wasmtime GitHub notifications bot (Jan 12 2025 at 19:35):VolodymyrBg requested wasmtime-core-reviewers for a review on PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 15:53):alexcrichton commented on PR #9989:
Thanks! Mind adding a test for this as well? (probably somewhere in
tests/all/cli_tests.rs)
Wasmtime GitHub notifications bot (Jan 13 2025 at 15:59):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:00):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:03):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:04):VolodymyrBg commented on PR #9989:
Thanks! Mind adding a test for this as well? (probably somewhere in
tests/all/cli_tests.rs)Thank you for the answer. I did what you asked
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:22):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:23):alexcrichton commented on PR #9989:
(I think there's a test failure though?)
Wasmtime GitHub notifications bot (Jan 13 2025 at 16:49):VolodymyrBg commented on PR #9989:
(I think there's a test failure though?)
Yes)) Gonna correct it soon
Wasmtime GitHub notifications bot (Jan 13 2025 at 17:53):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 17:54):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 18:07):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 19:41):fitzgen submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Jan 13 2025 at 19:41):fitzgen commented on PR #9989:
Looks like there are still some failing CI jobs that need to be fixed before this can merge.
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:10):VolodymyrBg commented on PR #9989:
Looks like there are still some failing CI jobs that need to be fixed before this can merge.
Working on it))
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:12):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:15):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:31):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:42):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 20:56):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 21:09):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 21:29):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 21:33):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 21:39):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 13 2025 at 21:49):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 13:44):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:01):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:19):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:31):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:34):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:44):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:46):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:57):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 14:59):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 15:10):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 16:28):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 16:40):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 16:53):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:05):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:14):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:18):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:19):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:19):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:20):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:24):VolodymyrBg updated PR #9989.
Wasmtime GitHub notifications bot (Jan 14 2025 at 17:25):VolodymyrBg updated PR #9989.
Last updated: Jan 24 2025 at 00:11 UTC