Stream: git-wasmtime

Topic: wasmtime / PR #9979 Fix some clippy warnings in the 2024 ...

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:45):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9979.

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:45):

alexcrichton requested dicej for a review on PR #9979.

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:45):

alexcrichton opened PR #9979 from alexcrichton:fix-some-warnings to bytecodealliance:main:

Not sure why these aren't firing on the 2021 edition, but I figured I'd just roll with it.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:50):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:51):

dicej commented on PR #9979:

Oops, CI has some &str vs. &String concerns.

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:59):

alexcrichton closed without merge PR #9979.

Wasmtime GitHub notifications bot (Jan 10 2025 at 15:59):

alexcrichton commented on PR #9979:

Oh!

This is related to the update to wit-bindgen, not clippy & editions. I got my wires crossed. This'll land when wit-bindgen is updated in this repo.

Last updated: Jan 24 2025 at 00:11 UTC