Stream: git-wasmtime

Topic: wasmtime / PR #9977 fix: `no_std` fix use without `unwind`

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 12:46):

JonasKruckenberg opened PR #9977 from JonasKruckenberg:jonas/no_std/no-unwind-feat to bytecodealliance:main:

As part of no_std support in cranelift this PR fixes uses of the isa/unwind module through cranelift so that cranelift can be compiled with the unwind feature (which depends on stdlib through gimli) disabled.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 12:46):

JonasKruckenberg requested abrown for a review on PR #9977.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 12:46):

JonasKruckenberg requested wasmtime-compiler-reviewers for a review on PR #9977.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:05):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:05):

bjorn3 created PR review comment:

Maybe compute_value_labels_ranges should be made to return ValueLabelsRanges::default(); when the unwind feature is disabled? Except for values which just so happen to be in registers, I don't think it is possible to generate valid debuginfo for locals when the unwind table is not also emitted.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 21:43):

SingleAccretion submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 21:43):

SingleAccretion created PR review comment:

Arguably, the register values are just as 'meaningless' in the no-unwind case as you need the unwind info to recover them (unless you are willing to disassemble code to guide your unwinder). Ultimately, the debug info production 'feature' is tightly coupled to the unwinding feature.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:26):

JonasKruckenberg updated PR #9977.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:27):

JonasKruckenberg submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:27):

JonasKruckenberg created PR review comment:

I marked compute_value_labels_ranges as available with the unwind feature too and made the Default changes at its only callsite, I think that's clearer than having the function exist but return a meaningless default value.

Last updated: Jan 24 2025 at 00:11 UTC